Allow the rotation of tokens #9484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
enhancement
3. to review
rullzer
requested review from
ChristophWurst,
MorrisJobke,
icewind1991 and
schiessle
Codecov Report
@@ Coverage Diff @@
## master #9484 +/- ##
============================================
+ Coverage 51.68% 51.69% +<.01%
- Complexity 25720 25721 +1
============================================
Files 1641 1641
Lines 96441 96443 +2
Branches 1393 1393
============================================
+ Hits 49850 49858 +8
+ Misses 46591 46585 -6
|
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good. Found one minor naming issue.
| * @param string $newTokenId | ||
| * @return IToken | ||
| */ | ||
| public function setNewToken(IToken $token, string $oldTokenId, string $newTokenId): IToken; |
Member
There was a problem hiding this comment.
Would it make sense to name the method rotate or similar?
Member
Author
There was a problem hiding this comment.
Yes will do. To much token in this indeed
|
|
||
| /** | ||
| * Get the name of the token | ||
| * @return string |
Member
There was a problem hiding this comment.
nitpick for future PRs: return type annotations are not necessary here 😉
This for example will allow rotating the apptoken for oauth Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
feature/noid/support_rotating_tokens
branch
from
de6812c to
aba2559
Compare
rullzer
added
4. to release
This was referenced May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This for example will allow rotating the apptoken for oauth
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl