Allow token to expire #9491
Merged
Allow token to expire #9491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
force-pushed
the
feature/noid/tokens_can_expire
branch
2 times, most recently
from
a9e1969 to
04f31ee
Compare
rullzer
force-pushed
the
feature/noid/tokens_can_expire
branch
2 times, most recently
from
4ce8863 to
9c78929
Compare
Codecov Report
@@ Coverage Diff @@
## master #9491 +/- ##
============================================
- Coverage 51.69% 51.69% -0.01%
- Complexity 25725 25735 +10
============================================
Files 1641 1643 +2
Lines 96454 96482 +28
Branches 1393 1393
============================================
+ Hits 49866 49878 +12
- Misses 46588 46604 +16
|
MorrisJobke
reviewed
May 17, 2018
| } | ||
|
|
||
| if ($token->getExpires() !== null && $token->getExpires() < $this->time->getTime()) { | ||
| throw new ExpiredTokenException($token); |
MorrisJobke
reviewed
May 17, 2018
| } | ||
|
|
||
| if ($token->getExpires() !== null && $token->getExpires() < $this->time->getTime()) { | ||
| throw new ExpiredTokenException($token); |
MorrisJobke
approved these changes
May 17, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Beside the little documentation nitpicks this looks fine 👍
However due to the nature of what we store in the token (encrypted passwords etc). We can't just delete the tokens because that would make the oauth refresh useless. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
feature/noid/tokens_can_expire
branch
from
9c78929 to
6b7cf46
Compare
rullzer
added
4. to release
This was referenced May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Allows for tokens to be expired (for OAuth).
To make sure auth doesn't happen with expired tokens we thrown an ExpiredTokenException (that does hold the token). This seemed easier than adding a check everywhere we use it.
The tokens need to stay in the DB else we can't refresh them later.