Skip to content

Conversation

@kevgathuku
Copy link
Contributor

Attempts to fix #9180

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@MorrisJobke
Copy link
Member

The CI failure is, because the commit message is missing the sign-off message. You can read more about this at https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work

If you have this branch checked out locally, you could adjust the existing commit by doing this:

git commit --amend -s
git push -f origin update-unshare-message

And welcome as first-time contributor to the Nextcloud project. 🎉

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Jun 18, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Jun 18, 2018
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
@kevgathuku kevgathuku force-pushed the update-unshare-message branch from 5d89d1c to 5d9c1d3 Compare June 18, 2018 10:12
@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #9893 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #9893   +/-   ##
=========================================
  Coverage     51.92%   51.92%           
  Complexity    25804    25804           
=========================================
  Files          1637     1637           
  Lines         95501    95501           
  Branches       1318     1318           
=========================================
  Hits          49592    49592           
  Misses        45909    45909
Impacted Files Coverage Δ Complexity Δ
...pps/files_sharing/lib/Activity/Providers/Users.php 0% <0%> (ø) 23 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.46% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@kevgathuku
Copy link
Contributor Author

Thanks for the pointers @MorrisJobke. I've been able to add the sign-off message.
And thanks for the welcome, it's exciting to contribute to this awesome project 😄

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish backport-request and removed 3. to review Waiting for reviews labels Jun 18, 2018
@juliusknorr juliusknorr merged commit 5b60508 into nextcloud:master Jun 18, 2018
@kevgathuku kevgathuku deleted the update-unshare-message branch June 18, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unfortunate notification wording when removing share

4 participants