-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Update message shown when unsharing a file #9893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update message shown when unsharing a file #9893
Conversation
MorrisJobke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me 👍
|
The CI failure is, because the commit message is missing the sign-off message. You can read more about this at https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work If you have this branch checked out locally, you could adjust the existing commit by doing this: And welcome as first-time contributor to the Nextcloud project. 🎉 |
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
5d89d1c to
5d9c1d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #9893 +/- ##
=========================================
Coverage 51.92% 51.92%
Complexity 25804 25804
=========================================
Files 1637 1637
Lines 95501 95501
Branches 1318 1318
=========================================
Hits 49592 49592
Misses 45909 45909
|
|
Thanks for the pointers @MorrisJobke. I've been able to add the sign-off message. |
Attempts to fix #9180