fix: path for workspaces #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Split this one from #879 as it's a fix for an existing problem and should be easier to review and get in. |
juliusknorr
reviewed
Jun 22, 2020
juliusknorr
reviewed
Jun 22, 2020
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Nice catch. Small comment, otherwise good from my side 👍
We need the relative path inside a users home directory to fetch the folder content for the filepicker. $file->getPath() gets the absolute path including username and files. Signed-off-by: Azul <azul@riseup.net>
Contributor
Author
|
@juliushaertl updated according to your comment. |
juliusknorr
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the relative path inside a users home directory
to fetch the folder content for the filepicker.
$file->getPath() gets the absolute path
including username and files.
Instead use $path which we already know and append the file name.
Frankly I have no idea if this is the right way to do this in the Controller
as I am not familiar with the
OCP/FilesAPI. This works for me and i hope it illustrates the problem. Feel free to fix in a different way.