fix: use OC.Files API to get file info #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@juliushaertl this should be a quick review. 👀 Could you please take a look so I can then adjust #879 to it? |
azul
force-pushed
the
fix/insert-image-during-call
branch
from
f9548d3 to
7cc0e46
Compare
juliusknorr
approved these changes
Aug 11, 2020
This api is also available in other apps while the internal structures used in fetchFileInfo are not. fixes #920 Signed-off-by: Azul <azul@riseup.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/insert-image-during-call
branch
from
7cc0e46 to
17f0047
Compare
Member
|
/backport c5fedf4 to stable19 |
Member
|
/backport c5fedf4 to stable18 |
|
The backport to stable19 failed. Please do this backport manually. |
|
The backport to stable18 failed. Please do this backport manually. |
Member
|
🙄 |
This was referenced Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This api is also available in other apps while
the internal structures used in fetchFileInfo are not.
Summary
The old code in question tried to use
OCA.Files.App.fileList:This is not available when using text in the viewer inside another app such as spreed during a call.