Merged
Conversation
The number of steps that are shared between the two jobs now exceeds the number of steps that differ. In this case, it seems more maintainable to use one job with per-step conditions for environment setup. This should also look nicer downstream - previously there was always one job that was skipped since they are meant to be mutually exclusive.
4 tasks
genehack
approved these changes
Oct 16, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The number of steps that are shared between the two jobs now exceeds the number of steps that differ. In this case, it seems more maintainable to use one job with per-step conditions for environment setup.
This should also look nicer downstream - previously there was always one job that was skipped since they are meant to be mutually exclusive.
Checklist