docs-ci: Check environment-file and pip-install-target inputs#111
Merged
docs-ci: Check environment-file and pip-install-target inputs#111
Conversation
These are marked as optional in the inputs block. There was an implicit assumption that it's required to have one of the inputs but not both. This can't be encoded in the inputs block so check the values as the very first step.
1 task
genehack
approved these changes
Oct 16, 2024
victorlin
force-pushed
the
victorlin/docs-ci-check-inputs
branch
from
733c234 to
937af63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
These are marked as optional in the inputs block. There was an implicit assumption that it's required to have one of the inputs but not both. This can't be encoded in the inputs block so check the values as the very first step.
Related issue(s)
Checklist