Conversation
@victorlin pointed out¹ that we could launder access to the secrets context thru the step env context without the need for an extra step. I avoid putting the secret itself into the environment (which only increases its potential visibility) and put only its presence/absence instead. ¹ <#38 (comment)>
1 task
Contributor
Author
|
(Typo in branch name, but ah well, I'm not going to shuffle things around and create new PR noise just for that.) |
So we can see that the optional docker.io login step continues to work (or not). Only added to one invocation of the workflow so we can compare it disabled in the other invocations.
victorlin
approved these changes
May 10, 2023
Member
victorlin
left a comment
victorlin
left a comment
There was a problem hiding this comment.
Nice, even better than my suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@victorlin pointed out¹ that we could launder access to the secrets context thru the step env context without the need for an extra step.
I avoid putting the secret itself into the environment (which only increases its potential visibility) and put only its presence/absence instead.
¹ #38 (comment)
Testing