Skip to content

pathogen-repo-ci: Avoid the secret-check step before docker.io login #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsibley merged 2 commits into from
May 10, 2023
Merged

pathogen-repo-ci: Avoid the secret-check step before docker.io login #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
515a900
pathogen-repo-ci: Avoid the secret-check step before docker.io login
tsibley May 10, 2023
d392130
ci: Test "secrets: inherit" for pathogen-repo-ci
tsibley May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
uses: ./.github/workflows/pathogen-repo-ci.yaml
with:
repo: nextstrain/zika
secrets: inherit

test-pathogen-repo-ci-no-example-data:
uses: ./.github/workflows/pathogen-repo-ci.yaml
Expand Down
12 changes: 5 additions & 7 deletions .github/workflows/pathogen-repo-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,12 @@ jobs:
# repos on GitHub but only available here to this reusable workflow when
# called with "secrets: inherit". On Docker Hub, the token is granted
# "public read-only" access.
- id: DOCKER_TOKEN_PUBLIC_READ_ONLY
name: Check if DOCKER_TOKEN_PUBLIC_READ_ONLY secret is available
#
# The secrets context is not allowed in "if:" conditions, so we must
# launder it thru env.
- if: env.token-available == 'true'
env:
DOCKER_TOKEN_PUBLIC_READ_ONLY: ${{ secrets.DOCKER_TOKEN_PUBLIC_READ_ONLY }}
run: |
tee -a "$GITHUB_OUTPUT" <<<available=${DOCKER_TOKEN_PUBLIC_READ_ONLY:+yes}

- if: steps.DOCKER_TOKEN_PUBLIC_READ_ONLY.outputs.available == 'yes'
token-available: ${{ secrets.DOCKER_TOKEN_PUBLIC_READ_ONLY != '' }}
name: Log in to docker.io
uses: docker/login-action@v2
with:
Expand Down