runner.conda: Explicitly install the latest package version during setup#312
Merged
runner.conda: Explicitly install the latest package version during setup#312
Conversation
This our intent and expectation, and it's good to be explicit about it.
It may surface more installation issues, such as the one we observed in
monkeypox CI¹ with the latest version not being installable, but
obscuring those or surfacing them later on is _probably_ worse than
addressing them head on earlier. This change will mean that any macOS
10.14 users, if any, would have to use
NEXTSTRAIN_CONDA_BASE_PACKAGE="nextstrain-base ==20230615T171309Z"
since newer versions aren't installable for them.²
This behaviour also parallels update's behaviour since "runner.conda:
Explicitly specify a nextstrain-base version when updating" (d6e4f2b).
It was an oversight (on my part) to not use the same behaviour during
setup, but at the time I was focused on fixing an update bug.
Related-to: <nextstrain/conda-base#41>
Related-to: <nextstrain/conda-base#42>
¹ <nextstrain/mpox#177>
² <nextstrain/conda-base#38>
Merged
2 tasks
joverlee521
approved these changes
Sep 18, 2023
Contributor
joverlee521
left a comment
joverlee521
left a comment
There was a problem hiding this comment.
Confirmed that this no longer silently downgrades to nextstrain-base ==20230615T171309Z when I run nextstrain setup conda --force on macOS 10.14
Contributor
Author
|
Woo! |
Contributor
Author
|
Ugh, forgot the changelog. Fixed in 1e8b12f. |
This was referenced Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This our intent and expectation, and it's good to be explicit about it. It may surface more installation issues, such as the one we observed in monkeypox CI¹ with the latest version not being installable, but obscuring those or surfacing them later on is probably worse than addressing them head on earlier. This change will mean that any macOS 10.14 users, if any, would have to use
since newer versions aren't installable for them.²
This behaviour also parallels update's behaviour since "runner.conda: Explicitly specify a nextstrain-base version when updating" (d6e4f2b). It was an oversight (on my part) to not use the same behaviour during setup, but at the time I was focused on fixing an update bug.
Related-to: nextstrain/conda-base#41
Related-to: nextstrain/conda-base#42
¹ nextstrain/mpox#177
² nextstrain/conda-base#38
Checklist