Merged
Conversation
…/vendored subrepo: subdir: "ingest/vendored" merged: "9082700" upstream: origin: "https://github.com/nextstrain/ingest" branch: "main" commit: "9082700" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
The previous commit was created by the following command:
git subrepo clone https://github.com/nextstrain/ingest ingest/vendored
Add a section in the README on how to use this directory in the future.
Remove the copies in this repo and update references.
Remove the copies in this repo and update references. Add new positional arguments required by the centralized scripts.
2 tasks
joverlee521
added a commit
to nextstrain/shared
that referenced
this pull request
Jul 31, 2023
Revisiting our previous decisions in #3 after @victorlin did more testing with the monkeypox repo with `git subtree` in nextstrain/mpox#162 and `git subrepo` in nextstrain/mpox#164.
7 tasks
Contributor
|
Doing a test run which will include Attach to test build on AWS Batch with: Files should be uploaded to |
joverlee521
approved these changes
Jul 31, 2023
Contributor
joverlee521
left a comment
joverlee521
left a comment
There was a problem hiding this comment.
Thanks for starting this off @victorlin!
The test run successfully completed and all of the expected files were uploaded.
I've never figured out the best way to test Slack notifications and triggers other than ensuring the individual scripts work as expected outside the full workflow. The changes look good to me, so I'd be happy to just have this merged and monitor the automated workflows for any hiccups.
This was referenced Aug 4, 2023
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Begin usage of centralized ingest scripts and add details on how to pull new updates from the central repo.
Related issue(s)
Testing
upload(ref)Post-merge: