Merged
Conversation
Closed
21 tasks
* Add core limit for tests * Update setup.R * Update tests/testthat/setup.R Co-authored-by: mrcaseb <38586519+mrcaseb@users.noreply.github.com> --------- Co-authored-by: mrcaseb <38586519+mrcaseb@users.noreply.github.com>
Member
Author
|
nflreadr is finally on CRAN so we can now require v1.4 with the .for_cran function |
I plan to deprecate those functions anyways and they are slow
it is multithreaded and we can't control it even magick devs skip related tests on cran
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait for cran approval