Skip to content

Add core limit for tests#47

Merged
mrcaseb merged 3 commits intoCRAN-1.2.0from
dt-corelimit
Aug 9, 2023
Merged

Add core limit for tests#47
mrcaseb merged 3 commits intoCRAN-1.2.0from
dt-corelimit

Conversation

@tanho63
Copy link
Member

@tanho63 tanho63 commented Aug 8, 2023

No description provided.

@tanho63 tanho63 requested a review from mrcaseb August 8, 2023 13:39
@mrcaseb
Copy link
Member

mrcaseb commented Aug 8, 2023

This code doesn't work because testthat::teardown_env() is just an environment.

https://testthat.r-lib.org/reference/teardown_env.html

@tanho63
Copy link
Member Author

tanho63 commented Aug 8, 2023

Yep am idiot

Co-authored-by: mrcaseb <38586519+mrcaseb@users.noreply.github.com>
@mrcaseb mrcaseb merged commit e4ead19 into CRAN-1.2.0 Aug 9, 2023
@mrcaseb mrcaseb deleted the dt-corelimit branch August 9, 2023 13:58
mrcaseb added a commit that referenced this pull request Sep 18, 2023
* Prepare CRAN 1.2.0 release

* submission

* take care of cran cpu threshold

* Add core limit for tests (#47)

* Add core limit for tests

* Update setup.R

* Update tests/testthat/setup.R

Co-authored-by: mrcaseb <38586519+mrcaseb@users.noreply.github.com>

---------

Co-authored-by: mrcaseb <38586519+mrcaseb@users.noreply.github.com>

* fix format string

* redirect headshots

* update logo list with new primary bears logo

* news bullet regarding Bears logo

* update gt output

* update install instructions to use pak

* add plot.tag examples to getting started article

* add gt examples

* require nflreadr 1.4.0 and update check yaml

* increase time out time to avoid early cancels

* put latest headshot in combined map

* submission file

* change env var for test setup and submit again

* I need to set OMP env var because of magick smh

* add comment

* submit the last freakin time

* don't run gridtext examples
I plan to deprecate those functions anyways and they are slow

* rewrite the multithread catcher a bit

* skip on cran if test runs magick
it is multithreaded and we can't control it
even magick devs skip related tests on cran

* holy s, yet another submission

* lower required nflreadr version because of nflverse package

* submit

---------

Co-authored-by: Tan Ho <38083823+tanho63@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants