Skip to content

Conversation

@sbethur
Copy link
Contributor

@sbethur sbethur commented Mar 30, 2020

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Update these methods in nidigital to use sites repeated capability:

  • fetch_history_ram_cycle_information
  • get_history_ram_sample_count
  • is_site_enabled

List issues fixed by this Pull Request below, if any.

What testing has been done?

Added new unit tests and system tests

Methods updated:
 - fetch_history_ram_cycle_information
 - get_history_ram_sample_count
 - is_site_enabled
@sbethur sbethur requested a review from marcoskirsch March 30, 2020 04:23
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #1359 into master will decrease coverage by 2.96%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   91.85%   88.88%   -2.97%     
==========================================
  Files          20       31      +11     
  Lines        3620     7016    +3396     
==========================================
+ Hits         3325     6236    +2911     
- Misses        295      780     +485     
Flag Coverage Δ
#codegenunittests 88.21% <ø> (ø)
#nidcpowersystemtests 98.58% <ø> (?)
#nidigitalsystemtests 58.31% <ø> (?)
#nidmmsystemtests 95.48% <ø> (?)
#nifakeunittests 96.36% <100.00%> (+0.04%) ⬆️
#nifgensystemtests 96.91% <ø> (?)
#nimodinstsystemtests 87.23% <ø> (?)
#nimodinstunittests 95.37% <ø> (ø)
#niscopesystemtests 83.15% <ø> (?)
#nisesystemtests 100.00% <ø> (?)
#niswitchsystemtests 98.11% <ø> (?)
#nitclksystemtests 100.00% <ø> (?)
#nitclkunittests 95.45% <ø> (ø)
Impacted Files Coverage Δ
generated/nifake/nifake/_converters.py 96.61% <100.00%> (+0.18%) ⬆️
generated/niscope/niscope/waveform_info.py 57.35% <0.00%> (ø)
generated/nidigital/nidigital/_library.py 56.70% <0.00%> (ø)
generated/nidmm/nidmm/_library.py 95.48% <0.00%> (ø)
...digital/nidigital/history_ram_cycle_information.py 100.00% <0.00%> (ø)
generated/nise/nise/_library.py 100.00% <0.00%> (ø)
generated/nifgen/nifgen/_library.py 96.91% <0.00%> (ø)
generated/niswitch/niswitch/_library.py 98.11% <0.00%> (ø)
generated/nimodinst/nimodinst/_library.py 87.23% <0.00%> (ø)
generated/niscope/niscope/_library.py 86.69% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5d7ec...d4f95ef. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some methods in nidigital could (should?) use sites rep cap

3 participants