Accept multiple error codes, descriptions in nifgen system test test_error_message #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Beginning with NI-FGEN 2023Q3, the error returned in the nifgen system test "test_error_message" has changed, causing the test to fail in our internal test suite. When we update the version of NI-FGEN installed to nimi-bot, the failure will occur in nimi-python PR checks as well.
This updates the test to accept both the new error code and descrption and the old ones.
List issues fixed by this Pull Request below, if any.
What testing has been done?
Ran the nifgen system tests with NI-FGEN 2023Q4 (in-dev version).