fix: only inherit waitUntil and platform context in fetch#3224
Merged
Conversation
pi0
changed the title
compatibilityDate note (#3190)
Deploying nitrojs with
|
| Latest commit: |
0b156be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18de2828.nitrojs.pages.dev |
| Branch Preview URL: | https://fix-platform-ctx.nitrojs.pages.dev |
pi0
changed the title
pi0
changed the title
waitUntil and platform context in fetch
pi0
added a commit
that referenced
this pull request
Mar 18, 2025
1 task
This was referenced Jul 12, 2025
Merged
luc122c
pushed a commit
to luc122c/unjs-nitro
that referenced
this pull request
Jul 17, 2025
s1gr1d
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Sep 11, 2025
…17596) Since Nitro v2.11.7, the platform-specific properties like `cloudlfare` and `cf` are nested under `_platform` (nitrojs/nitro#3224). The `isEventType` function is updated to reflect this change. stumbled across this while working on this: #17588
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nuxt/nuxt#31375
Fixing a regression (revealed) from #3155
When calling a fetch with a relative base URL in a server context, nitro uses an internal fetch mechanism without an actual network round trip.
Event context has to be (partially) shared so that platform-specific contexts like
event.cfandevent.waitUntilare inherited and work. However, we should never share other context keys (including the cached value of the route rule that corresponds to the main event, not the sub-event).It was not revealed before because before #3155, the proxy route rule was kicking in before h3 route handler.
This PR fixes the root cause by only inheriting an internal namespace of the provider context +
waitUntil(Note: this PR only targets v2 as direct fetch mechanism being updated with h3 v2 migration)