Skip to content

Enable the select tests on powerpc and mips #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jul 12, 2018
Merged

Enable the select tests on powerpc and mips #927

bors merged 1 commit into from
Jul 12, 2018
+0 −9

Conversation

@jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Jul 11, 2018

They pass at least on my machine with QEMU, so the underlying bugs might
have been fixed.

@jonas-schievink
Enable the select tests on powerpc and mips
b572415 
They pass at least on my machine with QEMU, so the underlying bugs might
have been fixed.
@asomers
Copy link
Member

asomers commented Jul 11, 2018

When you originally disabled those tests, did they fail reliably or intermittently?

@jonas-schievink
Copy link
Contributor Author

jonas-schievink commented Jul 11, 2018

Oh, I didn't disable them, I just copied them from another file in 885a1f7. @Susurrus disabled them in #590. I've run them a few times and they haven't failed yet, so I doubt it's an intermittent failure.

@asomers
Copy link
Member

asomers commented Jul 12, 2018

Ok, that should be fine then.

bors r+

bors bot added a commit that referenced this pull request Jul 12, 2018
@bors @jonas-schievink
Merge #927
237ec7b 
927: Enable the select tests on powerpc and mips r=asomers a=jonas-schievink

They pass at least on my machine with QEMU, so the underlying bugs might
have been fixed.

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 12, 2018

Build succeeded

@bors bors bot merged commit b572415 into nix-rust:master Jul 12, 2018
@jonas-schievink jonas-schievink deleted the select-tests branch July 12, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonas-schievink @asomers