Skip to content

Enable the select tests on powerpc and mips #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into from
Jul 12, 2018
+0 −9
Merged

Enable the select tests on powerpc and mips #927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/sys/select.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,14 +273,7 @@ mod tests {
assert_eq!(set.highest(), Some(7));
}

// powerpc-unknown-linux-gnu currently fails on the first `assert_eq` because
// `select()` returns a 0 instead of a 1. Since this test has only been run on
// qemu, it's unclear if this is a OS or qemu bug. Just disable it on that arch
// for now.
// FIXME: Fix tests for powerpc and mips
// FIXME: Add a link to an upstream qemu bug if there is one
#[test]
#[cfg_attr(any(target_arch = "powerpc", target_arch = "mips"), ignore)]
fn test_select() {
let (r1, w1) = pipe().unwrap();
write(w1, b"hi!").unwrap();
Expand All @@ -301,7 +294,6 @@ mod tests {
}

#[test]
#[cfg_attr(any(target_arch = "powerpc", target_arch = "mips"), ignore)]
fn test_select_nfds() {
let (r1, w1) = pipe().unwrap();
write(w1, b"hi!").unwrap();
Expand All @@ -322,7 +314,6 @@ mod tests {
}

#[test]
#[cfg_attr(any(target_arch = "powerpc", target_arch = "mips"), ignore)]
fn test_select_nfds2() {
let (r1, w1) = pipe().unwrap();
write(w1, b"hi!").unwrap();
Expand Down