Enable modernize-use-integer-sign-comparison check#4581
Merged
Conversation
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
nlohmann
force-pushed
the
modernize-use-integer-sign-comparison
branch
from
d9c7322 to
bf50bb6
Compare
nlohmann
added
the
review needed
codenut
reviewed
Jan 2, 2025
slowriot
pushed a commit
to slowriot/json
that referenced
this pull request
Jan 10, 2025
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #4559 after merging #4577.
Background: A new version of Clang-Tidy added a
modernize-use-integer-sign-comparisoncheck which failed on the code - mostly, because conversions likestatic_cast<std::size_t>(-1). These have been replaced withstd::numeric_limits<std::size_t>::max()in #4577. This PR en-enabled the Clang-Tidy check and fixes some test files.