Skip to content

Enable modernize-use-integer-sign-comparison check #4581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nlohmann merged 1 commit into from
Jan 2, 2025
Merged

Enable modernize-use-integer-sign-comparison check #4581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ Checks: '*,
-modernize-type-traits,
-modernize-use-constraints,
-modernize-use-designated-initializers,
-modernize-use-integer-sign-comparison,
-modernize-use-nodiscard,
-modernize-use-ranges,
-modernize-use-std-numbers,
Expand Down
2 changes: 1 addition & 1 deletion tests/src/unit-alt-string.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class alt_string
public:
using value_type = std::string::value_type;

static constexpr auto npos = static_cast<std::size_t>(-1);
static constexpr auto npos = (std::numeric_limits<std::size_t>::max)();

alt_string(const char* str): str_impl(str) {}
alt_string(const char* str, std::size_t count): str_impl(str, count) {}
Expand Down
4 changes: 2 additions & 2 deletions tests/src/unit-class_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class SaxEventLogger

bool start_object(std::size_t elements)
{
if (elements == static_cast<std::size_t>(-1))
if (elements == (std::numeric_limits<std::size_t>::max)())
{
events.emplace_back("start_object()");
}
Expand All @@ -100,7 +100,7 @@ class SaxEventLogger

bool start_array(std::size_t elements)
{
if (elements == static_cast<std::size_t>(-1))
if (elements == (std::numeric_limits<std::size_t>::max)())
{
events.emplace_back("start_array()");
}
Expand Down
4 changes: 2 additions & 2 deletions tests/src/unit-class_parser_diagnostic_positions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class SaxEventLogger

bool start_object(std::size_t elements)
{
if (elements == static_cast<std::size_t>(-1))
if (elements == (std::numeric_limits<std::size_t>::max)())
{
events.emplace_back("start_object()");
}
Expand All @@ -105,7 +105,7 @@ class SaxEventLogger

bool start_array(std::size_t elements)
{
if (elements == static_cast<std::size_t>(-1))
if (elements == (std::numeric_limits<std::size_t>::max)())
{
events.emplace_back("start_array()");
}
Expand Down
8 changes: 4 additions & 4 deletions tests/src/unit-deserialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ struct SaxEventLogger : public nlohmann::json_sax<json>

bool start_object(std::size_t elements) override
{
if (elements == static_cast<std::size_t>(-1))
if (elements == (std::numeric_limits<std::size_t>::max)())
{
events.emplace_back("start_object()");
}
Expand All @@ -101,7 +101,7 @@ struct SaxEventLogger : public nlohmann::json_sax<json>

bool start_array(std::size_t elements) override
{
if (elements == static_cast<std::size_t>(-1))
if (elements == (std::numeric_limits<std::size_t>::max)())
{
events.emplace_back("start_array()");
}
Expand Down Expand Up @@ -131,7 +131,7 @@ struct SaxEventLoggerExitAfterStartObject : public SaxEventLogger
{
bool start_object(std::size_t elements) override
{
if (elements == static_cast<std::size_t>(-1))
if (elements == (std::numeric_limits<std::size_t>::max)())
{
events.emplace_back("start_object()");
}
Expand All @@ -156,7 +156,7 @@ struct SaxEventLoggerExitAfterStartArray : public SaxEventLogger
{
bool start_array(std::size_t elements) override
{
if (elements == static_cast<std::size_t>(-1))
if (elements == (std::numeric_limits<std::size_t>::max)())
{
events.emplace_back("start_array()");
}
Expand Down