Dockerfile and instructions #327
Conversation
|
Great! To avoid having the flag admin_create we should fix #326 |
| @@ -0,0 +1,32 @@ | |||
| FROM node:5.11-wheezy | |||
There was a problem hiding this comment.
By removing 5.11-wheezy, I think we are guaranteed to get the latest, should we change it to that? is it good practice?
There was a problem hiding this comment.
Pinning is probably the better idea, always updating from latest is handy when developing and cuts down on "update base image to ..." commits, but pinned versions mean repeatable builds and always knowing where you're building from, in particular it means that the version of the base image is tracked in git which I consider to be important.
|
@rhiaro don't worry about the variable, there will be no need for that soon, we will be using |
|
|
|
Actually if we're going to include a template acl as its own file we might as well automate the input of the WebID in the dockerfile since @KitB found a solution. Until the |
Dockerfile
Outdated
|
|
||
| EXPOSE 8443 | ||
|
|
||
| CMD ["node", "/src/bin/ldnode.js", "--port=8443", "--ssl-key=/opt/ldnode/certs/ssl-key.pem", "--ssl-cert=/opt/ldnode/certs/ssl-cert.pem"] |
There was a problem hiding this comment.
consider
ENTRYPOINT ["node"]
CMD ["/src/bin/ldnode.js" ...]
Dockerfile
Outdated
| <#owner>\n\ | ||
| a n0:Authorization;\n\ | ||
| n0:accessTo <./>;\n\ | ||
| n0:agent ' + $admin_user + '\n\ |
There was a problem hiding this comment.
should this be ' ' or < > ?
is this missing ; ?
There was a problem hiding this comment.
Yeah it should, fixing that with my next updates (it somehow worked anyway though.. is your turtle parser lax?)
| && npm install | ||
|
|
||
| ENTRYPOINT ["node", "/src/bin/ldnode.js"] | ||
| CMD ["--port=8443", "--ssl-key=/opt/ldnode/certs/ssl-key.pem", "--ssl-cert=/opt/ldnode/certs/ssl-cert.pem", "--root=/src/data"] No newline at end of file |
There was a problem hiding this comment.
please add an EXPOSE 8443 line to let users (and docker) know that you're expecting to expose that port in the container :)
|
Merged #607 Can revisit this again in January when letsencrypt release wildcard certificates. |
5 participants
First pass Dockerfile, plus instructions in readme.
Works, but would appreciate review by @KitB for best practices/glaring holes.
@nicola, I used the acl we adapted from gold the other day, but let me know if this needs shortening or something.