-
Notifications
You must be signed in to change notification settings - Fork 304
Dockerfile and instructions #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
002ee2a
c5df357
c7868b4
c3fc0a6
ddeb738
79b375e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| FROM node:5.11-wheezy | ||
|
|
||
| RUN cd /opt \ | ||
| && mkdir -p ldnode/certs && cd ldnode/certs \ | ||
| && openssl genrsa 2048 > ssl-key.pem \ | ||
| && openssl req -new -x509 -nodes -sha256 -days 3650 -key ssl-key.pem -subj '/CN=*.localhost' > ssl-cert.pem | ||
|
|
||
| COPY . /src | ||
| RUN cd /src && mkdir data \ | ||
| && npm install | ||
|
|
||
| ENTRYPOINT ["node", "/src/bin/ldnode.js"] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i presume this has changed to |
||
| CMD ["--port=8443", "--ssl-key=/opt/ldnode/certs/ssl-key.pem", "--ssl-cert=/opt/ldnode/certs/ssl-cert.pem", "--root=/src/data"] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add an |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By removing 5.11-wheezy, I think we are guaranteed to get the latest, should we change it to that? is it good practice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning is probably the better idea, always updating from latest is handy when developing and cuts down on "update base image to ..." commits, but pinned versions mean repeatable builds and always knowing where you're building from, in particular it means that the version of the base image is tracked in git which I consider to be important.