Skip to content

nginx: Redirect old inspector docs (node executable) #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rvagg merged 3 commits into from
Apr 9, 2018
Merged

nginx: Redirect old inspector docs (node executable) #1219

rvagg merged 3 commits into from
Apr 9, 2018

Conversation

@fhemberger
Copy link
Contributor

@fhemberger fhemberger commented Apr 8, 2018

Turns out node was linking to nodejs.org/en/docs/inspector.
This fixes the redirect as well.

Ref: nodejs/nodejs.org#1619

@refack
Copy link
Contributor

refack commented Apr 8, 2018

From nodejs/nodejs.org#1619:
The binary refers to the docs in
https://github.com/nodejs/node/blob/9a6dd07e8d93c7208c6698dfec1296f5caec9948/src/inspector_socket_server.cc#L107-L108
(when running node --inspect)

refack

This comment was marked as off-topic.

Sign in to view

@refack refack added the website label Apr 8, 2018
@cjihrig cjihrig mentioned this pull request Apr 9, 2018
Merged
3 tasks
@rvagg rvagg merged commit d62e636 into nodejs:master Apr 9, 2018
@richardlau richardlau mentioned this pull request Apr 9, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

website

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fhemberger @refack @rvagg