test: verify inspector help url works #19887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Apr 9, 2018
richardlau
approved these changes
Apr 9, 2018
XadillaX
approved these changes
Apr 9, 2018
trivikr
approved these changes
Apr 9, 2018
lpinca
approved these changes
Apr 9, 2018
BridgeAR
approved these changes
Apr 9, 2018
Member
|
Note: nodejs/build#1219 landed. |
jasnell
approved these changes
Apr 9, 2018
richardlau
reviewed
Apr 9, 2018
Member
There was a problem hiding this comment.
If #19871 lands in its current form, this will need to be updated.
Contributor
Author
|
Irrelevant CI: https://ci.nodejs.org/job/node-test-pull-request/14178/ |
This commit adds basic functionality testing of the help URL printed when the inspector starts. PR-URL: nodejs#19887 Refs: nodejs#19871 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
This commit adds basic functionality testing of the help URL printed when the inspector starts. PR-URL: #19887 Refs: #19871 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds basic functionality testing of the help URL printed when the inspector starts.
Refs: #19871
Note that this test will fail until #19871 or nodejs/build#1219 land. If you want to see it working until then, just add+ '/'to the end ofhelpUrl.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes