feat: Node.js #1688
Closed
feat: Node.js #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
requested changes
Apr 5, 2022
Member
nschonni
left a comment
nschonni
left a comment
There was a problem hiding this comment.
Mixing in v14 Yarn stuff still
Member
|
Let's fix it? Seems like a bug in the update script |
Member
|
OK, I did the manual PR as well, but I'm fine holding off landing that one if you want to try and fix the script. Think we flagged the problem already in automation issue |
nodejs-github-bot
force-pushed
the
update-branch
branch
from
b4f7d0d to
36b01fb
Compare
Member
|
@SimenB looks like the commiter part is fixed now |
Member
|
yay! that's something 😅 |
Member
|
I won't have time to dig into this until tomorrow, but will give it a try then (if others want to try, please do! 👍 ) |
This was referenced Apr 7, 2022
Member
|
I think this should work now, but nodejs/unofficial-builds#56. |
nodejs-github-bot
force-pushed
the
update-branch
branch
from
36b01fb to
56583dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action