Skip to content

Added references to changelog maker tool and other minor fixes#394

Merged
NickNaso merged 2 commits intonodejs:masterfrom
NickNaso:create_release
Jan 8, 2019
Merged

Added references to changelog maker tool and other minor fixes#394
NickNaso merged 2 commits intonodejs:masterfrom
NickNaso:create_release

Conversation

@NickNaso
Copy link
Copy Markdown
Member

I added some reference about which tool use to generate the changelog and other minor fixes.

Comment thread doc/creating_a_release.md Outdated
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickNaso
Copy link
Copy Markdown
Member Author

NickNaso commented Jan 2, 2019

What do I need to change here? Someone could review?

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Jan 3, 2019

I think it just needs to be landed. You should have write access and be able to land it.

@NickNaso NickNaso merged commit 44f0695 into nodejs:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants