Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Apr 3, 2018

This code change updates "Breaking changes" link from "v0.4 to v0.6" to
generic "API/Breaking Changes" wiki

Checklist

This code change updates "Breaking changes" link from "v0.4 to v0.6" to
generic "API/Breaking Changes" wiki
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 3, 2018
@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Apr 3, 2018
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although, again, since we're not actually doing that anymore (never finished the 7-to-8 doc, there's no doc for 9.x, and AFAIK no realistic plans for a 10.x doc), I wonder if the paragraph should be removed entirely. (And an issue opened up, if there isn't already one, to figure out how to make this a thing we do again.)

@trivikr
Copy link
Member Author

trivikr commented Apr 3, 2018

@lpinca
Copy link
Member

lpinca commented Apr 4, 2018

👍 for removing the paragraph completely.

@trivikr
Copy link
Member Author

trivikr commented Apr 4, 2018

The paragraph with "breaking changes" wiki link is removed in new PR #19795
Closing this PR

@trivikr trivikr closed this Apr 4, 2018
@trivikr trivikr deleted the trivikr-patch-4 branch April 14, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants