Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Apr 4, 2018

Breaking changes wiki is not updated, so removing the paragraph as per comments by:

Checklist

Breaking changes wiki is not updated, so removing the paragraph
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 4, 2018
@trivikr trivikr mentioned this pull request Apr 4, 2018
2 tasks
@vsemozhetbyt vsemozhetbyt added meta Issues and PRs related to the general management of the project. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 4, 2018
@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2018
@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 4, 2018
@trivikr
Copy link
Member Author

trivikr commented Apr 5, 2018

Landed in 422ac61

@trivikr trivikr closed this Apr 5, 2018
trivikr added a commit that referenced this pull request Apr 5, 2018
Breaking changes wiki is not updated, so removing the paragraph

PR-URL: #19795
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 6, 2018
Breaking changes wiki is not updated, so removing the paragraph

PR-URL: #19795
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@trivikr trivikr deleted the trivikr-patch-5 branch April 14, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants