Skip to content

Conversation

@zkat
Copy link
Contributor

@zkat zkat commented Aug 8, 2015

Release notes: https://github.com/npm/npm/releases/tag/v2.13.4

Fixes npm version when used in git submodules.

r: @Fishrock123
r: @chrisdickinson

zkat and others added 3 commits August 7, 2015 22:04
Every npm version bump requires a few patches to be floated on
node-gyp for io.js compatibility. These patches are found in
03d1992,
5de334c, and
da730c7. This commit squashes
them into a single commit.

PR-URL: nodejs#990
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Conflicts:
	deps/npm/node_modules/node-gyp/lib/install.js
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: nodejs#1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@brendanashworth brendanashworth added the npm Issues and PRs related to the npm client dependency or the npm registry. label Aug 8, 2015
@bnoordhuis
Copy link
Member

The first commit in the changelog 404s for me. Should npm/npm@3e58c48 be npm/npm@2e58c48?

@zkat
Copy link
Contributor Author

zkat commented Aug 8, 2015

So confused as to how that happened. Thanks for finding it! It's been corrected. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes for nock in the files here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't include devDependency stuff in the distribution, but still bump the versions in package.json. Is that what you meant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh. Carry on. :)

@Fishrock123
Copy link
Contributor

@zkat sorry for forgetting, but 3.0.0 requires some new floating patches on node-gyp 😥

e52f963

&

902c9ca (squash together) 9f727f5

@jbergstroem
Copy link
Member

Might be nitpick, but is there any way to shrink these bumps? Most changes seems to be version or date changes -- is that for instance able to live somewhere else?

@Fishrock123
Copy link
Contributor

Might be nitpick, but is there any way to shrink these bumps? Most changes seems to be version or date changes -- is that for instance able to live somewhere else?

I guess it would be nice if the doc stuff was built on our build but I don't think the extra deps are worthwhile. You just need to mostly get used to skipping over a lot of similar docs stuff if you review the changes.

I suspect in git it compresses quite well, so I'm not worried about the doc version updates increasing tarball size.

@ChALkeR
Copy link
Member

ChALkeR commented Sep 6, 2015

Closing this as obsolete, #2696 introduced npm 2.14.2 in master.

@ChALkeR ChALkeR closed this Sep 6, 2015
@wraithgar wraithgar deleted the npm-2.13.4 branch June 26, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants