Skip to content

Put llhttp parser at dependencies list #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 5 commits into from
Nov 24, 2019
Merged

Put llhttp parser at dependencies list #2722

Trott merged 5 commits into from
Nov 24, 2019

Conversation

@juanarbol
Copy link
Member

@juanarbol juanarbol commented Oct 24, 2019

I saw today an error on dependencies list, http-parser listed on top, but llhttp seems to be the right name, also, llhttp had http-parser docs link.

@XhmikosR
Copy link
Contributor

XhmikosR commented Oct 25, 2019

Please check if this needs to be applied to translations.

@juanarbol
Copy link
Member Author

juanarbol commented Oct 27, 2019 •
edited
Loading

Yeap, an update is required in:

  1. ar
  2. ja
  3. ko
  4. pt-br
  5. ru
  6. uk
  7. zn-cn

But I don't know how to change the description in these languages; when I say description, I'm saying: "HTTP parsing is handled by a lightweight TypeScript and C library called llhttp..."

@richardlau richardlau mentioned this pull request Nov 20, 2019
Closed
@XhmikosR XhmikosR self-requested a review November 20, 2019 08:14
@XhmikosR XhmikosR requested review from Trott and richardlau November 20, 2019 09:04
@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 20, 2019

If anyone merges this and it's not me, please don't squash the patches.

juanarbol
juanarbol commented Nov 20, 2019
View reviewed changes
SEWeiTung
SEWeiTung approved these changes Nov 24, 2019
View reviewed changes
Copy link
Contributor

@SEWeiTung SEWeiTung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese looks good to me

@SEWeiTung
Copy link
Contributor

SEWeiTung commented Nov 24, 2019

@nodejs/website , Please have a review of the changed translations for all the other languages.

@yous
Copy link
Contributor

yous commented Nov 24, 2019 •
edited
Loading

ko/ seems okay.

@Trott
Copy link
Member

Trott commented Nov 24, 2019

I'm going to go ahead and land this. If any of the translations need improvements, they can certainly happen in a separate PR.

@Trott
Copy link
Member

Trott commented Nov 24, 2019

If anyone merges this and it's not me, please don't squash the patches.

Using 'Rebase and merge" rather than "Squash and merge'".

@Trott Trott merged commit 9ba3c15 into nodejs:master Nov 24, 2019
@Trott
Copy link
Member

Trott commented Nov 24, 2019

People can (and still) should check the translations to make sure we didn't introduce any errors here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau Awaiting requested review from richardlau

@Trott Trott Awaiting requested review from Trott

2 more reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@SEWeiTung SEWeiTung SEWeiTung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juanarbol @XhmikosR @SEWeiTung @yous @Trott