-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: new home page, blog engine, blog layouts and routing engine #6215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Lighthouse Results
|
fb72b5d to
1a9ebf3
Compare
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good so far - only had time for a quick pass
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this moving - momentum is building!
shanpriyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few nits. LGTM 🚀
Can we can just use the copy icon and remove the |
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Is the ask here to have it using the Home Page colors? |
|
Anyhow, @bmuenzenmeyer feel free to open an issue or PR regarding the Copy to Clipboard button as it is unrelated to this PR. It already became convoluted enough 😅 |







Description
This PR introduces several changes on the
next-datapieces of the Node.js Website, including:next-dataProvidersScreenshots
Branch Preview
https://nodejs-org-git-feat-new-blog-pagination-system-openjs.vercel.app
Validation
Blog Pages should work as expected, Pagination should work as expected, with the caveats that pages are now different routes.