Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Jan 7, 2024

Description

This PR introduces several changes on the next-data pieces of the Node.js Website, including:

  • Refactor on Promise-chains of next-data Providers
  • Refactor of Blog Data Generators, Providers and Fetch methods
  • Introduced new Pagination System for the Blog
    • The old Pagination System (years) became dedicated categories, so that they're still accessible on the web
  • Refactored how we allow dynamic URLs to be generated (DYNAMIC_ROUTES)
  • Cleanup on Blog-related code
  • Cleanup on constants (including Sentry constants, which are now separated to a dedicated file)
  • Introduced the Base Blog Category Layout
  • Fixed a few components (such as Preview, and Blog Cards)
    • Preview component content now resizes by the usage of Container Queries
  • Introduced the Blog Post Layout and Content Layout
  • Made adjustments on some Components and styles for some Layouts
  • Redesigned the Home Page based on feedback from the TSC

Screenshots

Screenshot 2024-01-09 at 18 02 14

Screenshot 2024-01-09 at 18 02 08

Screenshot 2024-01-09 at 18 00 43

Branch Preview

https://nodejs-org-git-feat-new-blog-pagination-system-openjs.vercel.app

Validation

Blog Pages should work as expected, Pagination should work as expected, with the caveats that pages are now different routes.

@ovflowd ovflowd added website redesign Issue/PR part of the Node.js Website Redesign feature-request labels Jan 7, 2024
@ovflowd ovflowd requested review from a team as code owners January 7, 2024 19:06
@vercel
Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 3:04pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jan 7, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 92 🟢 100 🟠 83 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 99 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟠 83 🟢 92 🔗

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far - only had time for a quick pass

@canerakdas
Copy link
Member

canerakdas commented Jan 12, 2024

According to the Lighthouse report, there were two minor problems with the blog detail page in mobile resolution, I updated them;

Apart from these two situations, the only thing that caught my attention during my checks is that the blog post layout is not centered. We can center this layout, but the background gradient is cut when it exceeds the maximum content width. So I'm not sure about this solution 🤔

image

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this moving - momentum is building!

@bmuenzenmeyer
Copy link
Contributor

A tiny design nit is that the Copy to Clipboard button is very prominent in the smaller coding snippets, which I find distracting from the content. This should be a de-emphasized control in my opinion.

image

Compare to the homepage which uses a de-emphasized version

image

Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few nits. LGTM 🚀

@shanpriyan
Copy link
Contributor

A tiny design nit is that the Copy to Clipboard button is very prominent in the smaller coding snippets, which I find distracting from the content. This should be a de-emphasized control in my opinion.

image

Compare to the homepage which uses a de-emphasized version

image

Can we can just use the copy icon and remove the Copy to clipboard text ? 🤔

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ovflowd
Copy link
Member Author

ovflowd commented Jan 14, 2024

A tiny design nit is that the Copy to Clipboard button is very prominent in the smaller coding snippets, which I find distracting from the content. This should be a de-emphasized control in my opinion.

image

Compare to the homepage which uses a de-emphasized version

image

Is the ask here to have it using the Home Page colors?

@ovflowd
Copy link
Member Author

ovflowd commented Jan 14, 2024

Anyhow, @bmuenzenmeyer feel free to open an issue or PR regarding the Copy to Clipboard button as it is unrelated to this PR. It already became convoluted enough 😅

@ovflowd ovflowd merged commit c811ac7 into main Jan 14, 2024
@ovflowd ovflowd deleted the feat/new-blog-pagination-system branch January 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

website redesign Issue/PR part of the Node.js Website Redesign

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants