Skip to content

fix: retry idempotent with original body #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ronag merged 1 commit into from
Nov 2, 2020
Merged

fix: retry idempotent with original body #471

ronag merged 1 commit into from
Nov 2, 2020

Conversation

@ronag
Copy link
Member

@ronag ronag commented Nov 2, 2020 •
edited
Loading

Fixes:#470

@ronag ronag requested a review from mcollina November 2, 2020 16:18
@benjamingr
Copy link
Member

benjamingr commented Nov 2, 2020

The fixes is probably wrong?

@ronag
Copy link
Member Author

ronag commented Nov 2, 2020

Updated ref

mcollina
mcollina approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 89af440 into master Nov 2, 2020
@ronag ronag deleted the idempotent-retry branch November 2, 2020 19:34
ronag added a commit that referenced this pull request Nov 2, 2020
@ronag
fix: retry idempotent with original body (#471)
8bf521e 
Fixes: #470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ronag @benjamingr @mcollina