Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/core/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -1081,8 +1081,6 @@ function write (client, request) {
if (!expectsPayload) {
client[kReset] = true
}

request.body = null
} else {
client[kWriting] = true

Expand Down
43 changes: 43 additions & 0 deletions test/client-idempotent-body.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
'use strict'

const { test } = require('tap')
const { Client } = require('..')
const { createServer } = require('http')

test('idempotent retry', (t) => {
t.plan(11)

const body = 'world'
const server = createServer((req, res) => {
let buf = ''
req.on('data', data => {
buf += data
}).on('end', () => {
t.strictDeepEqual(buf, body)
res.end()
})
})
t.tearDown(server.close.bind(server))

server.listen(0, () => {
const client = new Client(`http://localhost:${server.address().port}`, {
pipelining: 2
})
t.tearDown(client.close.bind(client))

const _err = new Error()

for (let n = 0; n < 4; ++n) {
client.stream({
path: '/',
method: 'PUT',
idempotent: true,
body
}, () => {
throw _err
}, (err) => {
t.strictEqual(err, _err)
})
}
})
})