feat: return body as consumable body #895
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: accept URL origin in Agent * fix: lint * fixup Co-authored-by: Robert Nagy <ronagy@icloud.com>
Member
Author
|
Tests need to be fixed quite extensively so I ask for some feedback before continuing down this route. |
ronag
force-pushed
the
node-stream
branch
3 times, most recently
from
9a59a27 to
a181898
Compare
Member
Author
ronag
force-pushed
the
node-stream
branch
13 times, most recently
from
6913094 to
0347991
Compare
ronag
commented
Jul 21, 2021
ronag
added
semver-major
ronag
force-pushed
the
node-stream
branch
5 times, most recently
from
47f70df to
c056e71
Compare
ronag
commented
Jul 21, 2021
Member
|
I think this should target a |
dnlup
reviewed
Jul 22, 2021
Contributor
dnlup
left a comment
dnlup
left a comment
There was a problem hiding this comment.
Love this! I think it's a great improvement in usability.
Member
Author
|
Related: nodejs/node#39483. I'm waiting for feedback there and hopefully finalization of the API before we land this so that we can have full compatibility. |
ronag
commented
Jul 22, 2021
| } | ||
|
|
||
| return this[kBody] | ||
| } |
Member
Author
There was a problem hiding this comment.
This is almost like BodyMixin from the web standard with the small exception of how to consume as Node stream.... anyone got suggestions on how that could/should look? @szmarczak @Ethan-Arrowood @mcollina @dnlup
ronag
force-pushed
the
node-stream
branch
2 times, most recently
from
8298466 to
50927b9
Compare
* unref() connectTimeout * clear out the connect timeout in all cases
Change undici.request to return a Body object with various consume helpers instead of regular node stream. This aligns with recent work on quic and web streams in node core.
This was referenced Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change undici.request to return a Body object with
various consume helpers instead of regular node stream.
This aligns with recent work on quic and web streams in
node core.