build,test: make test-grpc-packages pass again#352
Closed
santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
Closed
build,test: make test-grpc-packages pass again#352santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
Conversation
No need to install `@grpc/proto-loader` in Makefile's `test-agents-prereqs` target.
WalkthroughThe Makefile was updated to modify the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Makefile(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: santigimeno
PR: nodesource/nsolid#339
File: test/addons/nsolid-elf-utils/nsolid-elf-utils.js:13-14
Timestamp: 2025-07-08T14:46:47.806Z
Learning: In the nsolid test suite, native addon bindings are expected to be built beforehand; tests do not add fs.existsSync guards to skip when bindings are missing.
📚 Learning: in the nsolid test suite, native addon bindings are expected to be built beforehand; tests do not ad...
Learnt from: santigimeno
PR: nodesource/nsolid#339
File: test/addons/nsolid-elf-utils/nsolid-elf-utils.js:13-14
Timestamp: 2025-07-08T14:46:47.806Z
Learning: In the nsolid test suite, native addon bindings are expected to be built beforehand; tests do not add fs.existsSync guards to skip when bindings are missing.
Applied to files:
Makefile
📚 Learning: in nsolid test native addons (e.g., `test/addons/*/binding.cc`), additional javascript-facing argume...
Learnt from: santigimeno
PR: nodesource/nsolid#339
File: test/addons/nsolid-elf-utils/binding.cc:13-28
Timestamp: 2025-07-08T14:48:04.827Z
Learning: In nsolid test native addons (e.g., `test/addons/*/binding.cc`), additional JavaScript-facing argument validation is typically omitted because the tests supply well-formed inputs.
Applied to files:
Makefile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: test-macOS
- GitHub Check: build-tarball
- GitHub Check: test-linux (ubuntu-24.04-arm)
- GitHub Check: test-linux (ubuntu-24.04)
- GitHub Check: lint-js-and-md
- GitHub Check: build-docs
Comment on lines
1698
to
1700
| env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm install @opentelemetry/otlp-proto-exporter-base @grpc/grpc-js @grpc/proto-loader --prefix test/common/nsolid-otlp-agent --no-save --no-package-lock | ||
| env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm install @grpc/grpc-js @grpc/proto-loader --prefix test/common/nsolid-grpc-agent --no-save --no-package-lock | ||
| env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm install @grpc/grpc-js --prefix test/common/nsolid-grpc-agent --no-save --no-package-lock | ||
|
|
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify nsolid-grpc-agent no longer imports @grpc/proto-loader
@grpc/proto-loader has been removed from the install list, so any residual require('@grpc/proto-loader') in test/common/nsolid-grpc-agent/** will crash the tests at runtime.
Please confirm the agent code was cleaned up accordingly.
🏁 Script executed:
#!/bin/bash
# Detect stray proto-loader imports after its removal
rg -n "@grpc/proto-loader" test/common/nsolid-grpc-agent || trueLength of output: 145
Remove stray @grpc/proto-loader import from nsolid-grpc-agent
@grpc/proto-loader was removed from the install step, but it’s still imported in the agent code, which will lead to runtime failures:
• test/common/nsolid-grpc-agent/server.mjs:4
- import protoLoader from '@grpc/proto-loader';Please remove this import (and any related usage) to align the code with the updated dependencies.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In the Makefile around lines 1698 to 1700, the dependency @grpc/proto-loader was
removed from the install step for nsolid-grpc-agent, but the import statement
for it still exists in test/common/nsolid-grpc-agent/server.mjs at line 4. To
fix this, remove the import of @grpc/proto-loader from server.mjs and eliminate
any code that uses it to ensure the code matches the updated dependencies and
prevent runtime errors.
RafaelGSS
approved these changes
Aug 5, 2025
santigimeno
added a commit
that referenced
this pull request
Aug 5, 2025
No need to install `@grpc/proto-loader` in Makefile's `test-agents-prereqs` target. PR-URL: #352 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Member
Author
|
Landed in 766a071 |
santigimeno
added a commit
that referenced
this pull request
Aug 25, 2025
No need to install `@grpc/proto-loader` in Makefile's `test-agents-prereqs` target. PR-URL: #352 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to install
@grpc/proto-loaderin Makefile'stest-agents-prereqstarget.Summary by CodeRabbit