Skip to content

build,test: make test-grpc-packages pass again #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santigimeno wants to merge 1 commit into from
Closed

build,test: make test-grpc-packages pass again #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1696,7 +1696,7 @@ test-agents-prereqs:
env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm install nan@latest --no-save --no-package-lock --prefix test/common/nsolid-zmq-agent/node_modules/zeromq
env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm run build:libzmq --prefix test/common/nsolid-zmq-agent/node_modules/zeromq
env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm install @opentelemetry/otlp-proto-exporter-base @grpc/grpc-js @grpc/proto-loader --prefix test/common/nsolid-otlp-agent --no-save --no-package-lock
env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm install @grpc/grpc-js @grpc/proto-loader --prefix test/common/nsolid-grpc-agent --no-save --no-package-lock
env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm install @grpc/grpc-js --prefix test/common/nsolid-grpc-agent --no-save --no-package-lock

Comment on lines 1698 to 1700
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify nsolid-grpc-agent no longer imports @grpc/proto-loader

@grpc/proto-loader has been removed from the install list, so any residual require('@grpc/proto-loader') in test/common/nsolid-grpc-agent/** will crash the tests at runtime.
Please confirm the agent code was cleaned up accordingly.

🏁 Script executed:

#!/bin/bash
# Detect stray proto-loader imports after its removal
rg -n "@grpc/proto-loader" test/common/nsolid-grpc-agent || true

Length of output: 145

Remove stray @grpc/proto-loader import from nsolid-grpc-agent

@grpc/proto-loader was removed from the install step, but it’s still imported in the agent code, which will lead to runtime failures:

• test/common/nsolid-grpc-agent/server.mjs:4

- import protoLoader from '@grpc/proto-loader';

Please remove this import (and any related usage) to align the code with the updated dependencies.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In the Makefile around lines 1698 to 1700, the dependency @grpc/proto-loader was
removed from the install step for nsolid-grpc-agent, but the import statement
for it still exists in test/common/nsolid-grpc-agent/server.mjs at line 4. To
fix this, remove the import of @grpc/proto-loader from server.mjs and eliminate
any code that uses it to ensure the code matches the updated dependencies and
prevent runtime errors.

.PHONY: test-agents-prereqs-clean
test-agents-prereqs-clean:
Expand Down
Loading