Skip to content

Conversation

@brandonros
Copy link
Contributor

@brandonros brandonros commented Feb 26, 2019

It'd be a huge help to me and the organization I work for if we could get these changes/features merged and released.

It adds the following features:

Transit secret engine: https://www.vaultproject.io/api/secret/transit/index.html

Database secret engine: https://www.vaultproject.io/docs/secrets/databases/index.html

cc @eheikes @ChadKillingsworth

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #115   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         139    139           
  Branches       34     34           
=====================================
  Hits          139    139
Impacted Files Coverage Δ
src/commands.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1d91b9...c1c9d1f. Read the comment docs.

@normano-cloud
Copy link

@kr1sp1n Can you pls look at this?

@brandonros
Copy link
Contributor Author

@kr1sp1n are we good here now?

@neilbryson
Copy link

neilbryson commented Jul 18, 2019

Any updates on this ?

Also, the typings in DefinitelyTyped must be deprecated should this PR be merged. I think the typings in DT should be updated instead.

@kr1sp1n kr1sp1n merged commit 0951e25 into nodevault:master Dec 3, 2019
@kr1sp1n
Copy link
Collaborator

kr1sp1n commented Dec 3, 2019

@brandonros @neilbryson @normano-cloud Sorry for the late reply.
It's published now as v0.9.12 https://www.npmjs.com/package/node-vault 🎉

@brandonros brandonros mentioned this pull request Dec 4, 2019
@EvanTedesco EvanTedesco mentioned this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants