Skip to content

Conversation

@brandonros
Copy link
Contributor

@brandonros brandonros commented Dec 4, 2019

Extension of #115

Not sure if index.d.ts needs to be moved to src/

Would also need an npm publish/release

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #142 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          139       139           
  Branches        34        34           
=========================================
  Hits           139       139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31565d...d74e251. Read the comment docs.

@gnarea
Copy link

gnarea commented Jan 16, 2020

This looks good to me. It'd be great if it were merged + released soon so I don't have to copy index.d.ts into my repo.

@brandonros
Copy link
Contributor Author

@kr1sp1n if you are able to merge + release, it would be a massive help! thanks brother!

@kr1sp1n kr1sp1n merged commit 9a27b0d into nodevault:master Mar 1, 2020
@kr1sp1n
Copy link
Collaborator

kr1sp1n commented Mar 1, 2020

@brandonros @gnarea Merged and release as v0.9.13 https://www.npmjs.com/package/node-vault/v/0.9.13 🎉 @brandonros thanks for your PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants