feat: adding OCSP revocation implementation#134
feat: adding OCSP revocation implementation#134priteshbandi merged 32 commits intonotaryproject:mainfrom
Conversation
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 90.32% 89.32% -1.00%
==========================================
Files 16 21 +5
Lines 1457 1677 +220
==========================================
+ Hits 1316 1498 +182
- Misses 110 142 +32
- Partials 31 37 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
|
I've made a new commit that address some of the unresolved comments. It may not perfectly address them (as a final decision had not been made for everything), but it should bring many aspects of the implementation closer to everyone's desired solution. |
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
|
1.18 is failing due to the incorporation of url.JoinPath (which was added in 1.19) to construct the url instead of adding the strings together. Rather than changing this back (since JoinPath is the better option), @shizhMSFT recommended a new PR to update the Go support window (Issue: #115). The PR can be found here: #135 |
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
…lementation Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
…emented Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
2a643ff
|
Signing issue is resolved. Somehow two were unsigned. I rebased reworded to add signatures then force pushed it. The diff befor and after the force push is the same (as seen here), so shouldn't require extensive re-review. |
This PR adds OCSP revocation checking to the Verify function using the notation-core-go's revocation package. This PR addresses part of the following issue: notaryproject/notation-core-go#124. It is dependent on notaryproject/notation-core-go#134 Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com> Signed-off-by: Kody Kimberl <59657721+kody-kimberl@users.noreply.github.com>
This PR adds a new package that will perform OCSP revocation checking for a certificate chain.
Based on my design from #132 and the specification here.
This PR addresses part of the following issue:
Once it is approved and merged, a second PR will implement this functionality into notation-go.
Signed-off-by: Kody Kimberl kody.kimberl.work@gmail.com