feat: adding OCSP revocation checks to Verify#295
Merged
priteshbandi merged 32 commits intonotaryproject:mainfrom Apr 20, 2023
Merged
feat: adding OCSP revocation checks to Verify#295priteshbandi merged 32 commits intonotaryproject:mainfrom
priteshbandi merged 32 commits intonotaryproject:mainfrom
Conversation
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
kody-kimberl
requested review from
JeyJeyGao,
NiazFK,
SteveLasker,
gokarnm,
justincormack,
patrickzheng200,
priteshbandi,
rgnote and
shizhMSFT
as code owners
byronchien
reviewed
Mar 29, 2023
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
byronchien
previously approved these changes
Mar 29, 2023
byronchien
previously approved these changes
Mar 29, 2023
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
rgnote
reviewed
Apr 4, 2023
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
…on-core-go Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <59657721+kody-kimberl@users.noreply.github.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 73.39% 74.39% +0.99%
==========================================
Files 23 23
Lines 2101 2175 +74
==========================================
+ Hits 1542 1618 +76
+ Misses 443 439 -4
- Partials 116 118 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
patrickzheng200
left a comment
patrickzheng200
left a comment
There was a problem hiding this comment.
LGTM with one nit comment.
shizhMSFT
reviewed
Apr 20, 2023
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
priteshbandi
approved these changes
Apr 20, 2023
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds OCSP revocation checking to the Verify function using the notation-core-go's revocation package
Based on my design from notaryproject/notation-core-go#132 and the specification here.
This PR addresses part of the following issue:
It is dependent on notaryproject/notation-core-go#134
Signed-off-by: Kody Kimberl kody.kimberl.work@gmail.com