update: Package notation refactoring#191
Merged
shizhMSFT merged 32 commits intonotaryproject:mainfrom Nov 11, 2022
Merged
Conversation
added 3 commits
November 8, 2022 13:59
This was referenced Nov 8, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
reviewed
Nov 8, 2022
added 4 commits
November 8, 2022 19:12
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 80.10% 77.34% -2.77%
==========================================
Files 31 33 +2
Lines 2071 2189 +118
==========================================
+ Hits 1659 1693 +34
- Misses 325 405 +80
- Partials 87 91 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
priteshbandi
reviewed
Nov 9, 2022
patrickzheng200
force-pushed
the
notation
branch
from
293d7a7 to
79b49af
Compare
added 5 commits
November 9, 2022 19:58
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Nov 9, 2022
shizhMSFT
reviewed
Nov 9, 2022
shizhMSFT
reviewed
Nov 10, 2022
added 2 commits
November 10, 2022 20:00
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
requested changes
Nov 10, 2022
rgnote
reviewed
Nov 10, 2022
added 3 commits
November 10, 2022 23:55
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Nov 11, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Nov 11, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This was referenced Nov 11, 2022
priteshbandi
approved these changes
Nov 11, 2022
Contributor
priteshbandi
left a comment
priteshbandi
left a comment
There was a problem hiding this comment.
LGTM with comments addressed.
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR review order: #190 -> #192 -> This PR -> #186.
This PR refactors the notation package, files intended to be reviewed in this PR:
internal/common, verification/trustpolicy and verification/truststore pakcages shall be reviewed in #192 already. Therefore, they can be skipped in this PR.
Files in internal/mock_origin, internal/registry, and internal/notation.go are there just for not breaking the old dependencies. They will be removed once the refactoring is done.