Skip to content

feat: Added trustpolicy and truststore packages under verification#192

Merged
shizhMSFT merged 21 commits intonotaryproject:mainfrom
patrickzheng200:tp/ts
Nov 9, 2022
Merged

feat: Added trustpolicy and truststore packages under verification#192
shizhMSFT merged 21 commits intonotaryproject:mainfrom
patrickzheng200:tp/ts

Conversation

@patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Nov 8, 2022

PR review order: #190 -> This PR -> #191 -> #186

This PR adds the trustpolicy and truststore packages under verification.

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Merging #192 (7e79d10) into main (49ba3a3) will decrease coverage by 1.43%.
The diff coverage is 79.19%.

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   80.78%   79.34%   -1.44%     
==========================================
  Files          22       24       +2     
  Lines        1717     1951     +234     
==========================================
+ Hits         1387     1548     +161     
- Misses        258      319      +61     
- Partials       72       84      +12     
Impacted Files Coverage Δ
verification/verifier.go 83.33% <ø> (ø)
verification/verifier_helpers.go 68.96% <ø> (ø)
registry/repository.go 33.84% <34.04%> (-57.70%) ⬇️
verification/truststore/truststore.go 52.94% <52.94%> (ø)
verification/trustpolicy/trustpolicy.go 96.10% <96.10%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Patrick Zheng added 5 commits November 9, 2022 11:14
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@shizhMSFT shizhMSFT requested review from gokarnm and rgnote November 9, 2022 08:26
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Patrick Zheng added 8 commits November 9, 2022 16:49
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 2 commits November 9, 2022 17:05
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 79b49af into notaryproject:main Nov 9, 2022
@patrickzheng200 patrickzheng200 deleted the tp/ts branch November 9, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments