fix: update plugin to add ContractVersion#207
Merged
shizhMSFT merged 7 commits intonotaryproject:mainfrom Nov 23, 2022
Merged
Conversation
JeyJeyGao
requested review from
patrickzheng200,
priteshbandi,
rgnote and
shizhMSFT
and removed request for
shizhMSFT
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 65.90% 66.64% +0.74%
==========================================
Files 23 23
Lines 1575 1559 -16
==========================================
+ Hits 1038 1039 +1
+ Misses 469 455 -14
+ Partials 68 65 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shizhMSFT
reviewed
Nov 17, 2022
Contributor
shizhMSFT
left a comment
shizhMSFT
left a comment
There was a problem hiding this comment.
Should we also check the contract version in the response by the package plugin?
JeyJeyGao
force-pushed
the
fix/plugin_add_contract_version
branch
from
f0181c4 to
fc4834d
Compare
JeyJeyGao
force-pushed
the
fix/plugin_add_contract_version
branch
2 times, most recently
from
335e26a to
ffaa0fe
Compare
shizhMSFT
reviewed
Nov 17, 2022
shizhMSFT
reviewed
Nov 17, 2022
Contributor
|
@JeyJeyGao Please rebase the PR. |
JeyJeyGao
force-pushed
the
fix/plugin_add_contract_version
branch
from
b90ee82 to
55aa3e5
Compare
shizhMSFT
reviewed
Nov 18, 2022
shizhMSFT
reviewed
Nov 18, 2022
shizhMSFT
reviewed
Nov 18, 2022
JeyJeyGao
force-pushed
the
fix/plugin_add_contract_version
branch
4 times, most recently
from
79e293b to
da4ce4b
Compare
JeyJeyGao
force-pushed
the
fix/plugin_add_contract_version
branch
from
c8d8413 to
d8e195b
Compare
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
force-pushed
the
fix/plugin_add_contract_version
branch
from
59deb50 to
03ff11a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test:
Added invalid contract version unit test.
Signed-off-by: Junjie Gao junjiegao@microsoft.com