Skip to content

feat: add notation certificate cleanup-test command#1231

Merged
30 commits merged intomainfrom
unknown repository
Mar 26, 2025
Merged

feat: add notation certificate cleanup-test command#1231
30 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 24, 2025

This PR adds notation certificate cleanup-test command with E2E tests.

Resolves #647

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost marked this pull request as draft March 24, 2025 03:21
Patrick Zheng added 2 commits March 24, 2025 15:14
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost closed this Mar 25, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost reopened this Mar 25, 2025
Patrick Zheng added 6 commits March 25, 2025 08:56
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 89.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.81%. Comparing base (536a032) to head (796337f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/notation/cert/cleanupTest.go 88.88% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
+ Coverage   76.54%   76.81%   +0.26%     
==========================================
  Files          67       68       +1     
  Lines        3727     3809      +82     
==========================================
+ Hits         2853     2926      +73     
- Misses        674      680       +6     
- Partials      200      203       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Patrick Zheng added 2 commits March 25, 2025 11:05
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost closed this Mar 25, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost reopened this Mar 25, 2025
Patrick Zheng added 2 commits March 25, 2025 16:28
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 3 commits March 25, 2025 17:03
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost marked this pull request as ready for review March 25, 2025 09:39
@ghost ghost changed the title feat: notation cert cleanup-test command feat: add notation certificate cleanup-test command Mar 25, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 3 commits March 26, 2025 11:09
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost closed this Mar 26, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost reopened this Mar 26, 2025
Patrick Zheng added 2 commits March 26, 2025 15:17
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested review from JeyJeyGao and shizhMSFT March 26, 2025 07:25
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT March 26, 2025 08:28
shizhMSFT
shizhMSFT previously approved these changes Mar 26, 2025
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 234d2ca into notaryproject:main Mar 26, 2025
7 checks passed
@ghost ghost deleted the clean-test branch March 26, 2025 09:26
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
…1231)

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support clean up the source key and certificate generated by Notation

2 participants

Comments