Skip to content

Comments

fix: increase e2e test stability on release-1.3 branch#1269

Merged
4 commits merged intorelease-1.3from
unknown repository
Apr 27, 2025
Merged

fix: increase e2e test stability on release-1.3 branch#1269
4 commits merged intorelease-1.3from
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Apr 27, 2025

This PR targets on the release-1.3 branch.

After the vote PR #1268 been merged, the e2e test on the release-1.3 branch is failing.

This is due to a bug on the e2e test, which did not pop up before the merge. Hence creating this new PR to fix it.

Patrick Zheng added 2 commits April 27, 2025 09:50
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.73%. Comparing base (001cc91) to head (04806e1).
Report is 2 commits behind head on release-1.3.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.3    #1269   +/-   ##
============================================
  Coverage        70.73%   70.73%           
============================================
  Files               48       48           
  Lines             2966     2966           
============================================
  Hits              2098     2098           
  Misses             674      674           
  Partials           194      194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Patrick Zheng added 2 commits April 27, 2025 10:07
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost changed the title fix: fix e2e test on release-1.3 branch fix: increase e2e test stability on release-1.3 branch Apr 27, 2025
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit facb58c into notaryproject:release-1.3 Apr 27, 2025
7 checks passed
@ghost ghost deleted the release-1.3 branch April 27, 2025 03:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants