Skip to content

fix: increase e2e test stability on release-1.3 branch #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4 commits merged into from Apr 27, 2025
Merged

fix: increase e2e test stability on release-1.3 branch #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5a9f57
fix e2e test
Apr 27, 2025
1d90d90
fix e2e test
Apr 27, 2025
967e1e4
fix e2e test urls
Apr 27, 2025
04806e1
update
Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions test/e2e/suite/command/sign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,8 @@ var _ = Describe("notation sign", func() {

It("with timestamping and invalid tsa server", func() {
Host(BaseOptions(), func(notation *utils.ExecOpts, artifact *Artifact, vhost *utils.VirtualHost) {
notation.ExpectFailure().Exec("sign", "--timestamp-url", "http://invalid.com", "--timestamp-root-cert", filepath.Join(NotationE2EConfigPath, "timestamp", "globalsignTSARoot.cer"), artifact.ReferenceWithDigest()).
MatchErrKeyWords("Error: timestamp: Post \"http://invalid.com\"").
MatchErrKeyWords("server misbehaving")
notation.ExpectFailure().Exec("sign", "--timestamp-url", "http://localhost.test", "--timestamp-root-cert", filepath.Join(NotationE2EConfigPath, "timestamp", "globalsignTSARoot.cer"), artifact.ReferenceWithDigest()).
MatchErrKeyWords("Error: timestamp: Post \"http://localhost.test\"")
})
})

Expand Down
6 changes: 3 additions & 3 deletions test/e2e/suite/plugin/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,15 @@ var _ = Describe("notation plugin install", func() {

It("with invalid plugin URL scheme", func() {
Host(nil, func(notation *utils.ExecOpts, _ *Artifact, vhost *utils.VirtualHost) {
notation.ExpectFailure().Exec("plugin", "install", "--url", "http://invalid", "--sha256sum", "abcd").
notation.ExpectFailure().Exec("plugin", "install", "--url", "http://localhost", "--sha256sum", "abcd").
MatchErrContent("Error: failed to download plugin from URL: only the HTTPS scheme is supported, but got http\n")
})
})

It("with invalid plugin URL", func() {
Host(nil, func(notation *utils.ExecOpts, _ *Artifact, vhost *utils.VirtualHost) {
notation.ExpectFailure().Exec("plugin", "install", "--url", "https://invalid.test", "--sha256sum", "abcd").
MatchErrKeyWords("failed to download plugin from URL https://invalid.test")
notation.ExpectFailure().Exec("plugin", "install", "--url", "https://localhost.test", "--sha256sum", "abcd").
MatchErrKeyWords("failed to download plugin from URL https://localhost.test")
})
})
})
Loading