Support managing plugin keys #168
Merged
SteveLasker merged 14 commits intonotaryproject:mainfrom May 18, 2022
Merged
Conversation
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
SteveLasker
approved these changes
Apr 27, 2022
Contributor
SteveLasker
left a comment
There was a problem hiding this comment.
👍 on the new notation plugin list output
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
gokarnm
approved these changes
May 5, 2022
Contributor
gokarnm
left a comment
There was a problem hiding this comment.
LGTM. Have a couple of minor comments. I'd ask a review from @shizhMSFT too as he wrote most of this code.
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
shizhMSFT
requested changes
May 7, 2022
Co-authored-by: Shiwei Zhang <shizh@microsoft.com> Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
5 tasks
shizhMSFT
reviewed
May 16, 2022
Contributor
shizhMSFT
left a comment
There was a problem hiding this comment.
I've also reopened some comments in the previous review as they are marked resolved without changes.
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Member
Author
@shizhMSFT I think I got them all now. |
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
shizhMSFT
approved these changes
May 17, 2022
Contributor
shizhMSFT
left a comment
There was a problem hiding this comment.
LGTM with one unresolved comment.
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Member
Author
Resolved |
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
* support plugin keys * bump CI to go 1.18 * upgrade notation-go * update plugins branch * reduce plugin print verbosity * bump notation-go * make key and cert name required * simplify NewSignerFromFiles * Apply suggestions from code review * remove unused package * fix plugin aliases * return printkey errors Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com> Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for:
notation plugin list:notation key add --plugin=foo --name=foo-key --id=foo-id.notation key list:notation key remove.Other changes:
pkg/configand reduced the API surface.@gokarnm @SteveLasker
Signed-off-by: qmuntal qmuntaldiaz@microsoft.com