Skip to content

Comments

Support managing plugin keys #168

Merged
SteveLasker merged 14 commits intonotaryproject:mainfrom
qmuntal:plugin-list
May 18, 2022
Merged

Support managing plugin keys #168
SteveLasker merged 14 commits intonotaryproject:mainfrom
qmuntal:plugin-list

Conversation

@qmuntal
Copy link
Member

@qmuntal qmuntal commented Apr 27, 2022

This PR adds support for:

  • Listing available plugins using notation plugin list:
> notation plugin list  
NAME   DESCRIPTION   VERSION   URL           SUPPORTED CONTRACTS   CAPABILITIES   ERROR                                                                      PATH
foo    friendly      1         example.com   [1]                   [cap]          executable name must be "notation-foo.exe" instead of "notation-baz.exe"   C:\Users\qmuntaldiaz\.notation\plugins\baz\notation-baz.exe
foo    friendly      1         example.com   [1]                   [cap]          <nil>                                                                      C:\Users\qmuntaldiaz\.notation\plugins\foo\notation-foo.exe
  • Adding plugin keys using notation key add --plugin=foo --name=foo-key --id=foo-id.
  • Listing plugin keys using notation key list:
> notation key list
NAME      KEY PATH   CERTIFICATE PATH   ID       PLUGIN NAME   
foo-key                                 foo-id   foo
  • Removing plugin keys using notation key remove.

Other changes:

  • Simplified the types in pkg/config and reduced the API surface.
  • Using go 1.18 Generics to operate on slices.
  • Improved how we are formatting lists to the standard output.

@gokarnm @SteveLasker

Signed-off-by: qmuntal qmuntaldiaz@microsoft.com

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal qmuntal requested a review from a team April 27, 2022 15:45
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the new notation plugin list output

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
qmuntal added 2 commits April 29, 2022 17:41
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have a couple of minor comments. I'd ask a review from @shizhMSFT too as he wrote most of this code.

qmuntal added 3 commits May 5, 2022 09:07
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal qmuntal requested a review from shizhMSFT May 9, 2022 08:06
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also reopened some comments in the previous review as they are marked resolved without changes.

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal
Copy link
Member Author

qmuntal commented May 16, 2022

I've also reopened some comments in the previous review as they are marked resolved without changes.

@shizhMSFT I think I got them all now.

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one unresolved comment.

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal
Copy link
Member Author

qmuntal commented May 17, 2022

LGTM with one unresolved comment.

Resolved

@SteveLasker SteveLasker merged commit f1173eb into notaryproject:main May 18, 2022
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
* support plugin keys
* bump CI to go 1.18
* upgrade notation-go
* update plugins branch
* reduce plugin print verbosity
* bump notation-go
* make key and cert name required
* simplify NewSignerFromFiles
* Apply suggestions from code review
* remove unused package
* fix plugin aliases
* return printkey errors

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>

Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants