Skip to content

Comments

feat: use new verify workflow#342

Merged
binbin-li merged 3 commits intonotaryproject:dev-rc.1from
binbin-li:change-verify
Sep 26, 2022
Merged

feat: use new verify workflow#342
binbin-li merged 3 commits intonotaryproject:dev-rc.1from
binbin-li:change-verify

Conversation

@binbin-li
Copy link
Contributor

@binbin-li binbin-li commented Sep 21, 2022

What?

Use the new verification workflow for the verify command. Therefore, we have to make some updates to support it.

  1. Remove all local verification related flags and arguments, including signatures, certs, certFiles, pull, local and mediaType.
  2. Add config flag so that users can set up verification plugin configs.
  3. Use the new verification workflow.
  4. Update the hello-signing.md.

Test

Updated the unit tests.
Command output example:
image

Signed-off-by: Binbin Li libinbin@microsoft.com

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Merging #342 (e929ed1) into dev-rc.1 (538b7fc) will increase coverage by 0.88%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##           dev-rc.1     #342      +/-   ##
============================================
+ Coverage     30.37%   31.26%   +0.88%     
============================================
  Files            26       26              
  Lines          1758     1705      -53     
============================================
- Hits            534      533       -1     
+ Misses         1207     1155      -52     
  Partials         17       17              
Impacted Files Coverage Δ
cmd/notation/verify.go 33.96% <16.66%> (+16.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shizhMSFT shizhMSFT added the dev Issue or PR related to dev branches label Sep 21, 2022
@binbin-li binbin-li force-pushed the change-verify branch 3 times, most recently from 5a954a7 to 5dabc5a Compare September 26, 2022 05:14
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin-li binbin-li merged commit 4bc23db into notaryproject:dev-rc.1 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Issue or PR related to dev branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants