Skip to content

Comments

update verify command to use ts/tp based verification workflow#370

Closed
rgnote wants to merge 1 commit intonotaryproject:mainfrom
rgnote:verify-command
Closed

update verify command to use ts/tp based verification workflow#370
rgnote wants to merge 1 commit intonotaryproject:mainfrom
rgnote:verify-command

Conversation

@rgnote
Copy link
Contributor

@rgnote rgnote commented Oct 8, 2022

Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #370 (04bee04) into main (230d427) will increase coverage by 0.90%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   30.54%   31.44%   +0.90%     
==========================================
  Files          25       25              
  Lines        1614     1555      -59     
==========================================
- Hits          493      489       -4     
+ Misses       1108     1053      -55     
  Partials       13       13              
Impacted Files Coverage Δ
cmd/notation/verify.go 34.88% <0.00%> (+16.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this PR has already been available and merged to the dev-rc.1 branch by #342 contributed by @binbin-li.

By comparing #342 and #370, this PR has the following items missing:

  • Verification config support
  • Doc update for docs/hello-signing.md
  • Print outcomes

@binbin-li
Copy link
Contributor

The content of this PR has already been merged to the dev-rc.1 branch by #342 contributed by @binbin-li.

By comparing #342 and #370, this PR has the following items missing:

  • Verification config support
  • Doc update for docs/hello-signing.md
  • Print outcomes

btw, in #359, I added support for both tag and digest. Maybe we need to support it in main as well.

@dtzar
Copy link
Contributor

dtzar commented Oct 13, 2022

Per the community call, @priteshbandi agreed to close this one in favor of #373 which has this plus additional code.

@rgnote
Copy link
Contributor Author

rgnote commented Oct 18, 2022

Closing the PR in favor of #373

@rgnote rgnote closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants