feat: support tagged reference

[binbin-li]

What?

1. Support passing in a reference in the format: registry/repository:v1. Before that, only a reference with digest tag is supported.
2. Refactor the print out format to be more readable.

Test

Success case:

Failure case:

Signed-off-by: Binbin Li libinbin@microsoft.com

[codecov-commenter]

Codecov Report

Merging #359 (0d2f8d7) into dev-rc.1 (4bc23db) will decrease coverage by 0.10%.
The diff coverage is 11.11%.

@@             Coverage Diff              @@
##           dev-rc.1     #359      +/-   ##
============================================
- Coverage     31.26%   31.15%   -0.11%     
============================================
  Files            26       26              
  Lines          1705     1711       +6     
============================================
  Hits            533      533              
- Misses         1155     1161       +6     
  Partials         17       17              

Impacted Files	Coverage Δ
cmd/notation/verify.go	30.50% <11.11%> (-3.46%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[JeyJeyGao]

LGTM

[yizha1]

Regarding the success case, is there an empty line before the digest? If yes, I suggest removing the empty line.

[binbin-li]

Regarding the success case, is there an empty line before the digest? If yes, I suggest removing the empty line.

that's the old screenshot, I've updated it.

[chloeyin]

BTW, could you use cmd.ParseFlagPluginConfig to parse the plugin config?

notation/cmd/notation/sign.go

Line 123 in 4bc23db

pluginConfig, err := cmd.ParseFlagPluginConfig(opts.pluginConfig)

We don't need to parse the config string manully.

[binbin-li]

BTW, could you use cmd.ParseFlagPluginConfig to parse the plugin config?

notation/cmd/notation/sign.go

Line 123 in 4bc23db

pluginConfig, err := cmd.ParseFlagPluginConfig(opts.pluginConfig)

We don't need to parse the config string manully.

Sure, thanks for calling it out.

[patrickzheng200]

LGTM